Fix maps not preserving float -0.0.
#1387
Open
+136
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjeline
force-pushed
the
bugfix/float_defaults
branch
from
24f98e3 to
c6bada9
Compare
Adds a new trait `IsDefault` - Allows overriding equality checking for floats - Has a default implementation for anything that implements PartialEq - Derived automatically as part of deriving `prost::Message`
aaronjeline
force-pushed
the
bugfix/float_defaults
branch
from
c6bada9 to
4443f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps currently don't preserve
-0.0. If you add-0.0as a value in a map, and read it, you will get0.0.This isn't true of other structures.
It happens because the default value is
0.0, and when adding a new value, the code checks if it is equal to the default value usingPartialEq, which for floats treats0.0and-0.0as equal.